Cache isMSAASwapChainSupported() result for EGL #9235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a caching mechanism to store the results of MSAA support queries. The results are stored in a vector, indexed by the power-of-two of the sample count.
There was a problem hiding this comment.
This is too complicated. We don't need to handle anything else than x4 for now, until someone asks for it. x8 and x16 are very uncommon on mobile, and x2 is virtually useless.
I don't want any code in isMSAA...Supported() this should just be a return statement.
The check for x4 can be done once during init.
poweifeng
reviewed
Sep 19, 2025
z3moon
force-pushed
the
zm/msaa-support-cached
branch
from
aca135a to
653f786
Compare
pixelflinger
requested changes
Sep 19, 2025
Comment on lines
500
to
502
| // Other sample counts are not cached, retrieve it. | ||
| LOG(INFO) << "MSAA sample count " << samples << " is queried, consider caching it."; | ||
| return checkIfMSAASwapChainSupported(samples); |
There was a problem hiding this comment.
just return false. I don't want anything else in this function so it can be noexcept.
|
|
||
| PlatformEGL::PlatformEGL() noexcept = default; | ||
| PlatformEGL::PlatformEGL() noexcept : OpenGLPlatform() { | ||
| mMSAA4XSupport = checkIfMSAASwapChainSupported(4); |
There was a problem hiding this comment.
this needs to be called from createDriver, because at this point eglInitialize() has not even been called.
z3moon
force-pushed
the
zm/msaa-support-cached
branch
from
3da59dd to
8fe8f82
Compare
pixelflinger
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a caching mechanism to store the results of MSAA support queries. The results are stored in a vector, indexed by the power-of-two of the sample count.