Remove deps on truth-java8-extension.
#8003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_808166739
branch
from
99f5ed0 to
69f04ad
Compare
Its classes [have been part of the core Truth artifact since 1.4.2](google/truth#746 (comment)). Since we now depend on only one Truth artifact, I also inlined our `truth.version` property. Exception: I kept it in Guava, since we share it across multiple `pom.xml` files. (We _could_ accomplish the same thing by using `dependencyManagement` there, but [we have recently avoided it](https://github.com/google/guava/blob/257bc194f6e5bedd02115693f7416a84c3e4ba25/pom.xml#L107-L111), and I have some reservations around it, anyway, since it may override a newer version from a dependency. Fortunately, that is mostly academic now that we have Dependabot set up for almost all our projects.) The other thing about Guava is that we do _not_ have Dependabot set up for it. By keeping the version in a property, we allow our lesser Dependabot substitute, `versions-maven-plugin`, to bump it, as discussed on cl/554548816. RELNOTES=n/a PiperOrigin-RevId: 808216999
copybara-service
bot
force-pushed
the
test_808166739
branch
from
69f04ad to
4c4f855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deps on
truth-java8-extension.Its classes have been part of the core Truth artifact since 1.4.2.
Since we now depend on only one Truth artifact, I also inlined our
truth.versionproperty. Exception: I kept it in Guava, since we share it across multiplepom.xmlfiles. (We could accomplish the same thing by usingdependencyManagementthere, but we have recently avoided it, and I have some reservations around it, anyway, since it may override a newer version from a dependency. Fortunately, that is mostly academic now that we have Dependabot set up for almost all our projects.) The other thing about Guava is that we do not have Dependabot set up for it. By keeping the version in a property, we allow our lesser Dependabot substitute,versions-maven-plugin, to bump it, as discussed on cl/554548816.RELNOTES=n/a