-
Notifications
You must be signed in to change notification settings - Fork 216
Add WidthCast operation to VAST. #3279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf77ceb to
5568cd3
Compare
mikex-oss
reviewed
Nov 3, 2025
5ca7da8 to
81e6674
Compare
Collaborator
Author
|
I also added a missing function to the C API while was here. |
Collaborator
Author
|
The test failures look unrelated and repro at head. |
mikex-oss
approved these changes
Nov 4, 2025
Collaborator
This was a TIv1 vs TIv2 diff, should be clean now as a result of 1798223. |
Examples: 14'(42), MyWidth'(x), (MyWidth+1)'(100)
81e6674 to
b21dc67
Compare
Collaborator
Author
|
Rebased to fix the failing tests. Also add TypeCast as that was also missing from VAST. |
mikex-oss
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples: 14'(42), MyWidth'(x), (MyWidth+1)'(100)