Skip to content

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Sep 16, 2025

📌 Summary

If merged, this PR adds eng docs for the advanced table column reorder feature.

🔗 External links

Jira ticket: HDS-XXX
Figma file: [if it applies]


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

Copy link

vercel bot commented Sep 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 3, 2025 11:17am
hds-website Ready Ready Preview Oct 3, 2025 11:17am

@jorytindall
Copy link
Contributor

I forgot I had already added the guidelines docs for this in the old PR. I'll let some other designers provide some feedback, but this is looking solid already!


!!! Info

Reorderable columns are not supported in instances of the Advanced Table that have nested rows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Reorderable columns are not supported in instances of the Advanced Table that have nested rows.
Reorderable columns are not supported in instances of the Advanced Table that have nested rows or pinnable columns.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed @dchyun 's suggestion for this with "sticky" rather than "pinned". Any opinions on which one is better? Probably doesn't matter a ton.

<br /><br />
When called, this function receives one positional argument:
<ul>
<li>an array of reordered column keys (e.g., ['name', 'age', 'height']).</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem to solve in this PR, but I'm now noticing that <li>'s nested inside of these Property blocks have a larger font size than the body text and it looks a off visually.

Copy link
Contributor

@heatherlarsen heatherlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorytindall I added a couple of notes about the guidelines tab.

Copy link
Contributor

@dchyun dchyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the content look all good to me. Just a couple questions about more content to add in other places.

heatherlarsen
heatherlarsen previously approved these changes Oct 1, 2025
jorytindall
jorytindall previously approved these changes Oct 1, 2025
shleewhite
shleewhite previously approved these changes Oct 2, 2025
heatherlarsen
heatherlarsen previously approved these changes Oct 2, 2025
@shleewhite shleewhite merged commit 1f06d45 into main Oct 3, 2025
11 checks passed
@shleewhite shleewhite deleted the zamoore/AdvancedTable/column-reordering-2__docs-p2 branch October 3, 2025 11:26
zamoore added a commit that referenced this pull request Oct 3, 2025
Co-authored-by: Jory Tindall <[email protected]>
Co-authored-by: shleewhite <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants