-
Notifications
You must be signed in to change notification settings - Fork 50
AdvancedTable
- Column reordering - Docs
#3194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdvancedTable
- Column reordering - Docs
#3194
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
I forgot I had already added the guidelines docs for this in the old PR. I'll let some other designers provide some feedback, but this is looking solid already! |
9f273df
to
ce8265a
Compare
|
||
!!! Info | ||
|
||
Reorderable columns are not supported in instances of the Advanced Table that have nested rows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reorderable columns are not supported in instances of the Advanced Table that have nested rows. | |
Reorderable columns are not supported in instances of the Advanced Table that have nested rows or pinnable columns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed @dchyun 's suggestion for this with "sticky" rather than "pinned". Any opinions on which one is better? Probably doesn't matter a ton.
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
<br /><br /> | ||
When called, this function receives one positional argument: | ||
<ul> | ||
<li>an array of reordered column keys (e.g., ['name', 'age', 'height']).</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a problem to solve in this PR, but I'm now noticing that <li>'s
nested inside of these Property blocks have a larger font size than the body text and it looks a off visually.
website/docs/components/table/advanced-table/partials/code/component-api.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/code/component-api.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/code/how-to-use.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/code/how-to-use.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/code/how-to-use.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorytindall I added a couple of notes about the guidelines tab.
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to the content look all good to me. Just a couple questions about more content to add in other places.
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Show resolved
Hide resolved
a182bc1
to
abc5ca2
Compare
1ec0afa
Co-authored-by: Jory Tindall <[email protected]> Co-authored-by: shleewhite <[email protected]>
📌 Summary
If merged, this PR adds eng docs for the advanced table column reorder feature.
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.