Remove ember-render-modifiers
#3252
Draft
+593
−528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zamoore
force-pushed
the
zamoore/hds-5516/remove-ember-render-modifiers
branch
from
b5a9a60 to
a289083
Compare
aklkv
reviewed
Oct 2, 2025
| } | ||
| ); | ||
|
|
||
| export default hdsRegisterElementModifier; |
There was a problem hiding this comment.
you might not want to have Modifier word at the end so it's a little cleaner in the future when you actually import it manually in gts files it would auto suggest correct one
|
@zamoore I have looked over the general direction, I think it looks pretty good, tho might looks more verbose for some but offers a lot more control in the long run |
zamoore
force-pushed
the
main-5.0.0
branch
3 times, most recently
from
3851d8f to
5d044c7
Compare
zamoore
force-pushed
the
zamoore/hds-5516/remove-ember-render-modifiers
branch
from
a289083 to
f794ca9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR will remove usage of
ember-render-modifiers.🛠️ Detailed description
TBD
📸 Screenshots
🔗 External links
Jira ticket: HDS-5516
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.