Skip to content

Conversation

mnafees
Copy link
Contributor

@mnafees mnafees commented Oct 10, 2025

Description

Fixes span naming according to convention. Also relocates /internal/telemetry to /pkg/telemetry for broader usage.

Type of change

  • Refactor (non-breaking changes to code which doesn't change any behaviour)

@mnafees mnafees self-assigned this Oct 10, 2025
Copy link

vercel bot commented Oct 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hatchet-docs Ready Ready Preview Comment Oct 16, 2025 4:24pm
hatchet-v0-docs Ready Ready Preview Comment Oct 16, 2025 4:24pm

@mnafees mnafees changed the title Fix OTel span naming convention Fix OTel span attribute naming convention Oct 10, 2025
Copy link
Contributor

@mrkaye97 mrkaye97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! is the plan to change the names of the spans themselves too?

@mnafees
Copy link
Contributor Author

mnafees commented Oct 16, 2025

@mrkaye97 yes sir, as part of a following PR!

@mnafees mnafees merged commit e2b1f13 into main Oct 16, 2025
48 of 50 checks passed
@mnafees mnafees deleted the nafees/telemetry-span-attrs branch October 16, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants