-
Notifications
You must be signed in to change notification settings - Fork 88
chore: add dependabot.yml #3725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: PavelSBorisov <[email protected]>
Test Results 20 files ± 0 280 suites +3 18m 5s ⏱️ -6s Results for commit 2501eaf. ± Comparison against base commit 0e189dc. This pull request removes 1 and adds 24 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Hey @PavelSBorisov, I noticed this PR hasn’t been updated in a while. Is it still relevant? |
Hey @quiet-node, yes it's still relevant but has been sitting on the back burner due to other priorities until now. |
Signed-off-by: PavelSBorisov <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
|
Hey @PavelSBorisov are there any updates on this? |
Signed-off-by: PavelSBorisov <[email protected]>
Updated in accordance with the comments, awaiting review. |
Signed-off-by: PavelSBorisov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor things.
Co-authored-by: Andrew Brandt <[email protected]> Signed-off-by: Pavel Borisov <[email protected]>
Signed-off-by: PavelSBorisov <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3725 +/- ##
==========================================
+ Coverage 86.66% 89.72% +3.06%
==========================================
Files 87 87
Lines 5039 5002 -37
Branches 1020 1008 -12
==========================================
+ Hits 4367 4488 +121
+ Misses 409 263 -146
+ Partials 263 251 -12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Hi @PavelSBorisov, we started to see the effects of this config file. We noticed that many, many PRs were created. The problem is that these many PRs degrade GHA performance substantially. Right after the PRs are created, workflows stop running for while. Is there is a way to create PRs in batches? Or at least for now, maybe even decrease the number of PRs created so we can continue working while dependabot PR workflows are running. I noticed this article https://docs.github.com/en/enterprise-cloud@latest/code-security/dependabot/dependabot-version-updates/optimizing-pr-creation-version-updates, maybe we can use the |
@acuarica the current dependabot PR flood is expected until everything is up to date, after which PRs would slow down. What we can do to ease the load a little meanwhile is apply a 1 day cooldown setting to the daily interval PRs - this would basically make dependabot open new PRs every other day for these deps instead of daily. We could, alternatively, significantly lower the number of dependabot PRs allowed to sit open at one time (from 20 to 10/5) which would mean that when dependabot performs the daily check, it would open a maximum of 10/5 PRs (if all the previous ones are closed) and so it would keep the runners busy for a lot less time. |
|
Hi Pavel, we discussed this internally with the team. We would like to apply your suggestions, that is
Over time we can increase this limit once most of the repo's dependencies are up to date. Would this be possible? |
Description:
Adding dependabot.yml
Related issue(s):
Fixes #3640
Notes for reviewer:
Checklist