-
Notifications
You must be signed in to change notification settings - Fork 93
feat: update getBalance method to require blockNumberOrTagOrHash parameter instead of allowing null (#3838)
#3859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…parameter instead of allowing null (hiero-ledger#3838) Signed-off-by: Michał Walczak <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
acuarica
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM looks like unit tests need some updates as well
packages/relay/src/lib/services/ethService/accountService/AccountService.ts
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #3859 +/- ##
=======================================
Coverage ? 41.29%
=======================================
Files ? 83
Lines ? 4770
Branches ? 970
=======================================
Hits ? 1970
Misses ? 2536
Partials ? 264
🚀 New features to boost your workflow:
|
…ent (hiero-ledger#3838) Signed-off-by: Michał Walczak <[email protected]>
…argument (hiero-ledger#3838) Signed-off-by: Michał Walczak <[email protected]>
simzzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…sing or null parameters (hiero-ledger#3838) Signed-off-by: Michał Walczak <[email protected]>
quiet-node
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@quiet-node @acuarica I noticed that I need to know which approach we want to take so I can get the tests to pass successfully. |
No, To recap, |
…pecs (hiero-ledger#3838) Signed-off-by: Michał Walczak <[email protected]>
quiet-node
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Great work!
Description:
Updated
getBalancemethod and related tests to accommodate parameter type change fromstring | nulltostring.Related issue(s):
Fixes #3838
Checklist