feat: deprecate ETH_CALL_DEFAULT_TO_CONSENSUS_NODE, OPERATOR_ID_ETH_SENDRAWTRANSACTION and OPERATOR_KEY_ETH_SENDRAWTRANSACTION
#3925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
acuarica
reviewed
Jul 11, 2025
Contributor
acuarica
left a comment
acuarica
left a comment
There was a problem hiding this comment.
looking good, left some small comments
packages/relay/src/lib/services/ethService/contractService/ContractService.ts
Outdated
Show resolved
Hide resolved
packages/relay/src/lib/services/ethService/contractService/ContractService.ts
Show resolved
Hide resolved
Signed-off-by: nikolay <[email protected]>
…transaction-operator-envs # Conflicts: # packages/relay/src/utils.ts
quiet-node
approved these changes
Jul 14, 2025
Contributor
quiet-node
left a comment
quiet-node
left a comment
There was a problem hiding this comment.
LGTM & Nice one! Feels much clearer and less indrection when it comes to handle eth_call logic and operator specification in general! Great work as always!
natanasow
deleted the
3918-deprecate-call_to_consensus-and-sendrawtransaction-operator-envs
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #3925 +/- ##
==========================================
+ Coverage 86.60% 86.74% +0.14%
==========================================
Files 87 87
Lines 5090 5039 -51
Branches 1040 1020 -20
==========================================
- Hits 4408 4371 -37
+ Misses 413 407 -6
+ Partials 269 261 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Once we remove the list of selectors for consensus redirection (
ETH_CALL_CONSENSUS_SELECTORS) here #3902. Now we can removeETH_CALL_DEFAULT_TO_CONSENSUS_NODEbecause its usage is tightly related to theETH_CALL_CONSENSUS_SELECTORS.Also, there are 2 more envs that are not being used within the codebase
OPERATOR_ID_ETH_SENDRAWTRANSACTIONandOPERATOR_KEY_ETH_SENDRAWTRANSACTION.Solution:
ETH_CALL_DEFAULT_TO_CONSENSUS_NODEenv and all its usageOPERATOR_ID_ETH_SENDRAWTRANSACTIONOPERATOR_KEY_ETH_SENDRAWTRANSACTIONRelated issue(s):
Fixes #3918
Notes for reviewer:
Checklist