Skip to content

feat: deprecate ETH_CALL_DEFAULT_TO_CONSENSUS_NODE, OPERATOR_ID_ETH_SENDRAWTRANSACTION and OPERATOR_KEY_ETH_SENDRAWTRANSACTION #3925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025
Merged

feat: deprecate ETH_CALL_DEFAULT_TO_CONSENSUS_NODE, OPERATOR_ID_ETH_SENDRAWTRANSACTION and OPERATOR_KEY_ETH_SENDRAWTRANSACTION #3925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce1d58f
chore: remove envs
natanasow Jul 11, 2025
f1d389c
chore: remove type param
natanasow Jul 11, 2025
f855465
chore: add test
natanasow Jul 11, 2025
24f4578
chore: resolve comments
natanasow Jul 14, 2025
a397818
Merge branch 'main' into 3918-deprecate-call_to_consensus-and-sendraw…
natanasow Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .env.http.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ OPERATOR_KEY_MAIN= # Operator private key used to sign transaction
# ========== ETH CALL CONFIGURATION ==========
# CONTRACT_CALL_GAS_LIMIT=50000000 # Maximum gas limit applied to eth_call endpoint
# ETH_CALL_CACHE_TTL=200 # Maximum time in ms to cache an eth_call response
# ETH_CALL_DEFAULT_TO_CONSENSUS_NODE=false # If true, eth_call first queries consensus node instead of mirror
# ETH_CALL_ACCEPTED_ERRORS=[] # List of acceptable error codes for eth_call requests for retry

# ========== FEE & GAS CONFIGURATION ==========
Expand Down
1 change: 0 additions & 1 deletion .env.ws.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ SUBSCRIPTIONS_ENABLED=true # Must be true for the WebSocket server to func
# MIRROR_NODE_AGENT_CACHEABLE_DNS=true # Enable DNS caching for mirror node

# ========== ETH CALL CONFIGURATION ==========
# ETH_CALL_DEFAULT_TO_CONSENSUS_NODE=false # If true, eth_call first queries consensus node instead of mirror
# CONSENSUS_MAX_EXECUTION_TIME=15000 # Max time in ms before TIMEOUT error
# SDK_REQUEST_TIMEOUT=10000 # Timeout for SDK execute() method
# CONTRACT_QUERY_TIMEOUT_RETRIES=3 # Maximum retries for failed contract call queries
Expand Down
1 change: 0 additions & 1 deletion charts/hedera-json-rpc-relay-websocket/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ config:
# MIRROR_NODE_AGENT_CACHEABLE_DNS:

# ========== ETH CALL CONFIGURATION ==========
# ETH_CALL_DEFAULT_TO_CONSENSUS_NODE:
# CONSENSUS_MAX_EXECUTION_TIME:
# SDK_REQUEST_TIMEOUT:
# CONTRACT_QUERY_TIMEOUT_RETRIES:
Expand Down
2 changes: 0 additions & 2 deletions charts/hedera-json-rpc-relay/environments/minikube.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ config:
HEDERA_NETWORK: {"127.0.01:50211":"0.0.3"}
OPERATOR_ID_MAIN: ""
OPERATOR_KEY_MAIN: ""
OPERATOR_ID_ETH_SENDRAWTRANSACTION: ""
OPERATOR_KEY_ETH_SENDRAWTRANSACTION: ""

rolling_restart:
enabled: true
Expand Down
2 changes: 0 additions & 2 deletions charts/hedera-json-rpc-relay/templates/secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,3 @@ type: Opaque
stringData:
OPERATOR_ID_MAIN: {{ .Values.config.OPERATOR_ID_MAIN | quote }}
OPERATOR_KEY_MAIN: {{ .Values.config.OPERATOR_KEY_MAIN | quote }}
OPERATOR_ID_ETH_SENDRAWTRANSACTION: {{ .Values.config.OPERATOR_ID_ETH_SENDRAWTRANSACTION | default (printf "%q" "") }}
OPERATOR_KEY_ETH_SENDRAWTRANSACTION: {{ .Values.config.OPERATOR_KEY_ETH_SENDRAWTRANSACTION | default (printf "%q" "") }}
1 change: 0 additions & 1 deletion charts/hedera-json-rpc-relay/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ config:
# ========== ETH CALL CONFIGURATION ==========
# CONTRACT_CALL_GAS_LIMIT:
# ETH_CALL_CACHE_TTL:
# ETH_CALL_DEFAULT_TO_CONSENSUS_NODE:
# ETH_CALL_ACCEPTED_ERRORS:

# ========== FEE & GAS CONFIGURATION ==========
Expand Down
1 change: 0 additions & 1 deletion docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ Unless you need to set a non-default value, it is recommended to only populate o
| `ETH_BLOCK_NUMBER_CACHE_TTL_MS` | "1000" | Time in ms to cache response from mirror node |
| `ETH_CALL_ACCEPTED_ERRORS` | "[]" | A list of acceptable error codes for eth_call requests. If an error code in this list is returned, the request will be retried. |
| `ETH_CALL_CACHE_TTL` | "200" | Maximum time in ms to cache an eth_call response. |
| `ETH_CALL_DEFAULT_TO_CONSENSUS_NODE` | "false" | Flag to set if eth_call logic should first query the mirror node. |
| `ETH_FEE_HISTORY_FIXED` | "true" | Flag to set if eth_feeHistory should return a fixed fee for the set of results. |
| `ETH_GET_BALANCE_CACHE_TTL_MS` | "1000" | Time in ms to cache balance returned |
| `ETH_GET_BLOCK_BY_RESULTS_BATCH_SIZE` | "25" | The number of contract results to request from the Mirror Node per batch durin an eth_getBlockByHash or eth_getBlockByNumber call |
Expand Down
2 changes: 1 addition & 1 deletion docs/rpc-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Below is a comprehensive table of all Ethereum JSON-RPC methods from the [Ethere
| [eth_accounts](https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_accounts) | **Implemented** - Returns `[]` | N/A | Always returns empty array per Infura behavior |
| [eth_blobBaseFee](https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_blobBaseFee) | **Implemented** - Returns `-32601` (Method not supported) | N/A | EIP-4844 blob transactions not supported |
| [eth_blockNumber](https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_blocknumber) | **Implemented** | Mirror Node | |
| [eth_call](https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_call) | **Implemented** | Mirror Node, Consensus Node (conditional) | Falls back to Consensus Node only if `ETH_CALL_DEFAULT_TO_CONSENSUS_NODE=true` |
| [eth_call](https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_call) | **Implemented** | Mirror Node | |
| [eth_chainId](https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_chainid) | **Implemented** | N/A | Returns configured chain ID from environment |
| [eth_coinbase](https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_coinbase) | **Implemented** - Returns `-32601` (Method not supported) | N/A | Fixed zero address as Hedera has no traditional coinbase |
| [eth_createAccessList](https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_createaccesslist) | **Not Implemented** - Returns `-32601` (Method not found) | N/A | |
Expand Down
18 changes: 0 additions & 18 deletions packages/config-service/src/services/globalConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,12 +214,6 @@ const _CONFIG = {
required: false,
defaultValue: 200,
},
ETH_CALL_DEFAULT_TO_CONSENSUS_NODE: {
envName: 'ETH_CALL_DEFAULT_TO_CONSENSUS_NODE',
type: 'boolean',
required: false,
defaultValue: false,
},
ETH_FEE_HISTORY_FIXED: {
envName: 'ETH_FEE_HISTORY_FIXED',
type: 'boolean',
Expand Down Expand Up @@ -587,24 +581,12 @@ const _CONFIG = {
required: false,
defaultValue: true,
},
OPERATOR_ID_ETH_SENDRAWTRANSACTION: {
envName: 'OPERATOR_ID_ETH_SENDRAWTRANSACTION',
type: 'string',
required: false,
defaultValue: null,
},
OPERATOR_ID_MAIN: {
envName: 'OPERATOR_ID_MAIN',
type: 'string',
required: false,
defaultValue: null,
},
OPERATOR_KEY_ETH_SENDRAWTRANSACTION: {
envName: 'OPERATOR_KEY_ETH_SENDRAWTRANSACTION',
type: 'string',
required: false,
defaultValue: null,
},
OPERATOR_KEY_FORMAT: {
envName: 'OPERATOR_KEY_FORMAT',
type: 'string',
Expand Down
1 change: 0 additions & 1 deletion packages/config-service/src/services/loggerService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { GlobalConfig } from './globalConfig';
export class LoggerService {
public static readonly SENSITIVE_FIELDS = [
GlobalConfig.ENTRIES.OPERATOR_KEY_MAIN.envName,
GlobalConfig.ENTRIES.OPERATOR_KEY_ETH_SENDRAWTRANSACTION.envName,
GlobalConfig.ENTRIES.GITHUB_TOKEN.envName,
GlobalConfig.ENTRIES.GH_ACCESS_TOKEN.envName,
];
Expand Down
6 changes: 0 additions & 6 deletions packages/relay/src/formatters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,11 +253,6 @@ const isHex = (value: string): boolean => {
return hexRegex.test(value);
};

const getFunctionSelector = (data?: string): string => {
if (!data) return '';
return data.replace(/^0x/, '').substring(0, 8);
};

const tinybarsToWeibars = (value: number | null, allowNegativeValues: boolean = false) => {
if (value && value < 0) {
// negative amount can be received only by CONTRACT_NEGATIVE_VALUE revert
Expand Down Expand Up @@ -301,7 +296,6 @@ export {
isValidEthereumAddress,
isHex,
ASCIIToHex,
getFunctionSelector,
mapKeysAndValues,
tinybarsToWeibars,
};
Loading
Loading