Skip to content

HPCC-34904 HR Translations for 10.0.x #20464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: candidate-10.0.x
Choose a base branch
from
Open

HPCC-34904 HR Translations for 10.0.x #20464

wants to merge 1 commit into from

Conversation

kunalaswani
Copy link
Contributor

Translations added for Croatian (HR).

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@kunalaswani
HPCC-34904 HR Translations for 10.0.x
6f995e8 
Translations added for Croatian (HR).

Signed-off-by: Kunal Aswani <[email protected]>
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-34904

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

Copilot
Copilot AI reviewed Sep 30, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Croatian (HR) translations to the HPCC Platform's ECL Watch web interface. The change implements localization support for Croatian users by providing translated text strings for the user interface.

Key changes:

  • Added comprehensive Croatian translations covering over 100 new UI strings
  • Updated existing translations for improved accuracy and consistency
  • Enhanced localization coverage for Croatian users

esp/src/src-dojo/nls/hr/hpcc.ts
BannerColorTooltip: "Promijenite boju pozadine gornje navigacije",
BannerMessage: "Poruka za Reklamni Blok",
BannerMessageTooltip: 'Promijenite naslov prikazan u gornjoj navigaciji (default "ECL Watch")',
BannerMessageTooltip: "Promijeni naslov prikazan u gornjoj navigaciji (zadano \"ECL Watch\")",
Copy link

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Croatian translation uses 'Promijeni' (imperative form) but should use 'Promijenite' to match the formal tone used consistently throughout the file. The correct translation should be 'Promijenite naslov prikazan u gornjoj navigaciji (zadano "ECL Watch")'.

Suggested change
BannerMessageTooltip: "Promijeni naslov prikazan u gornjoj navigaciji (zadano \"ECL Watch\")",
BannerMessageTooltip: "Promijenite naslov prikazan u gornjoj navigaciji (zadano \"ECL Watch\")",

Copilot uses AI. Check for mistakes.

esp/src/src-dojo/nls/hr/hpcc.ts
Filter: "Filter",
FilterDetails: "Opis Filtera",
FilterMetricsTooltip: "Ovo će se prema zadanim postavkama filtrirati na temelju stupca \"Scope\". Za filtriranje bilo kojeg drugog stupca upotrijebite naziv stupca kao prefiks za pretraživanje, npr.: \"Naziv datoteke: Spill\"",
FilterMetricsTooltip: "Ovo će se prema zadanim postavkama filtrirati na temelju stupca \"Opseg\". Za filtriranje prema bilo kojem drugom stupcu upotrijebite naziv stupca kao prefiks pretrage, npr.: \"Naziv datoteke:izlijevanje\"",
Copy link

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation contains inconsistent terminology. 'izlijevanje' should be 'Spill' (as used in the original) to maintain technical consistency, and there should be a space after the colon. The correct translation should be: '"Naziv datoteke: Spill"'.

Suggested change
FilterMetricsTooltip: "Ovo će se prema zadanim postavkama filtrirati na temelju stupca \"Opseg\". Za filtriranje prema bilo kojem drugom stupcu upotrijebite naziv stupca kao prefiks pretrage, npr.: \"Naziv datoteke:izlijevanje\"",
FilterMetricsTooltip: "Ovo će se prema zadanim postavkama filtrirati na temelju stupca \"Opseg\". Za filtriranje prema bilo kojem drugom stupcu upotrijebite naziv stupca kao prefiks pretrage, npr.: \"Naziv datoteke: Spill\"",

Copilot uses AI. Check for mistakes.

esp/src/src-dojo/nls/hr/hpcc.ts
LogFilterStartDateTooltip: "Uključite redke log dnevnika od početka datog vremenskog raspona",
LogFiltersUnavailable: "Filteri zapisnika nisu dostupni.",
LogFilterTimeRequired: 'Odaberite ili "Od i do datuma" ili "Relativni vremenski raspon"',
LogFilterTimeRequired: "Odaberite ili \"Datum od i do\" ili \"Međuspremnik relativnog vremena zapisnika\"",
Copy link

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation 'Međuspremnik relativnog vremena zapisnika' appears to be incorrect. 'Međuspremnik' means 'cache/buffer' which doesn't match the context. Based on the original English, this should be 'Relativni vremenski raspon' or similar phrasing for 'Relative time range'.

Suggested change
LogFilterTimeRequired: "Odaberite ili \"Datum od i do\" ili \"Međuspremnik relativnog vremena zapisnika\"",
LogFilterTimeRequired: "Odaberite ili \"Datum od i do\" ili \"Relativni vremenski raspon\"",

Copilot uses AI. Check for mistakes.

esp/src/src-dojo/nls/hr/hpcc.ts
WorkunitOptions: "Opcije radne jedinice",
Workunits: "Radne Jedinice",
WorkUnitScopeDefaultPermissions: "Unaprijed Definisane Dozvole za Prostor za Radne Jedinice",
WorkunitSummarySplitter: "SAŽETAK SAŽETAK WORKUNIT",
Copy link

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation contains a duplicate word 'SAŽETAK SAŽETAK WORKUNIT'. This should be simplified to 'SAŽETAK WORKUNIT' or 'WORKUNIT SAŽETAK' to avoid redundancy.

Suggested change
WorkunitSummarySplitter: "SAŽETAK SAŽETAK WORKUNIT",
WorkunitSummarySplitter: "SAŽETAK WORKUNIT",

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@emuharemagic emuharemagic Awaiting requested review from emuharemagic

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kunalaswani