-
Notifications
You must be signed in to change notification settings - Fork 38
Fixes for local dev / CI builds #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for local dev / CI builds #51
Conversation
…ybook versions for storybook build issue
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
I've investigated a little further and it looks like the
|
Thanks for looking into this @tr00st! Nice work. Yes, I'd be very happy to update anything we can to fix any build issues here. Updating TypeScript & node types should be fine, I don't think we're doing anything especially complex related to either one so that sounds great to me. Before this is merged, can you also sign the CLA please? It's very short - just confirming that you're happy to license your contribution to the project, and you have the right to do so. |
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
CLA is now sorted - just needed to get employer permission. I've looked into updating typescript... Looks like doing so would break support for Node v12, which is in the current set of CI build environments. Worth noting that Node 12 hit EOL about 3 years ago, but fully understand that removing a node version is probably something to think about 😄 So - looks to me like the options are to either:
Going for "be eager and rollback later", I've pushed a pair of commits that does the latter - rough summary:
Fully aware that removal for Node v12 might be more controversial - so happy to revert the above if you'd prefer. ...also noticed the socket security warning on |
Yep, I'm perfectly happy to drop Node 12 testing from CI. We don't officially define supported Node versions here since it's a frontend package and it shouldn't make any meaningful difference. Also happy to ignore the buffer warning - it's a false positive and doesn't really make any difference here anyway. Merged 👍 Thanks! |
Oh by the way, in case you're not aware, all contributors to all repos in the org get free HTTP Toolkit Pro - if that's interesting just let know and I'll set you up with an account. |
As raised in #50 - couple of dev fixes.