[Inference] Let's use lowercase left/right truncation direction parameter #3548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
added a commit
to huggingface/huggingface.js
that referenced
this pull request
Nov 13, 2025
…eter (#1841) First spotted by @alvarobartt on [slack](https://huggingface.slack.com/archives/C064Z3GRU3U/p1762871481747849?thread_ts=1743434022.621759&cid=C064Z3GRU3U) (internal). The `FeatureExtractionInputTruncationDirection` parameter defined in the feature-extraction specs currently have capitalized values `Left` / `Right`. This comes from TEI implementation from which we pulled the specs. Let's switch it to lowercase values for consistency with all other specs. In addition to this PR, we should: - update TEI to accept `left`/`right` (not even sure we want backward compatibility on this) => @alvarobartt would you be able to handle this? - update `huggingface_hub` => I can take care of this huggingface/huggingface_hub#3548 - update `hub-docs` => will happen automatically I think it's fine to have breaking change for this. Moreover, specs / docs are there more for information but are rarely enforced (expect in TEI) so it shouldn't break anything client-side.
Contributor
|
(failing tests unrelated) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart of huggingface/huggingface.js#1841 (related to internal slack thread).
The
FeatureExtractionInputTruncationDirectionparameter defined in the feature-extraction specs currently have capitalized values Left / Right. This comes from TEI implementation from which we pulled the specs. Let's switch it to lowercase values for consistency with all other specs.