fix(client): http2_connect_detect_close uses in-memory i/o
#3946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see hyperium#3896. this commit rewrites this test to use `tokio::io::duplex(..)`. this should help avoid spurious failures, by replacing `setup_tk_test_server()` with an in-memory i/o type. Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
to cratelyn/hyper
that referenced
this pull request
Sep 8, 2025
see hyperium#3896. this commit ports an assortment of test cases for the client to an in-memory socket using `tokio::io::duplex()`. this should help reduce test flakes related to TCP close behavior. this supersedes hyperium#3946. Signed-off-by: katelyn martin <[email protected]>
|
#3947 supersedes this. closing! |
seanmonstar
pushed a commit
that referenced
this pull request
Sep 8, 2025
see #3896. this commit ports an assortment of test cases for the client to an in-memory socket using `tokio::io::duplex()`. this should help reduce test flakes related to TCP close behavior. this supersedes #3946. Signed-off-by: katelyn martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3896.
this commit rewrites this test to use
tokio::io::duplex(..).this should help avoid spurious failures, by replacing
setup_tk_test_server()with an in-memory i/o type.