Skip to content

Conversation

@jintukumardas
Copy link
Contributor

PR description

Fixes colored output in terminal logging

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@jflo jflo self-requested a review October 21, 2025 18:38
@jflo jflo assigned jflo and unassigned jflo Oct 21, 2025
@macfarla
Copy link
Contributor

@jflo related to this PR I have another PR to add a test that ensures logging goes to stdout #9341
so that test should pass before and after this PR

Copilot AI review requested due to automatic review settings November 12, 2025 02:44
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested and this works for me locally, color is back

@macfarla
Copy link
Contributor

@jflo do you have a strong opinion - any issues or concerns?

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@macfarla macfarla assigned macfarla and unassigned jflo Nov 12, 2025
@macfarla macfarla enabled auto-merge (squash) November 12, 2025 21:12
@macfarla macfarla merged commit 78408f1 into hyperledger:main Nov 12, 2025
46 checks passed
jflo added a commit to jflo/besu that referenced this pull request Nov 17, 2025
* Fix colored output in terminal

Signed-off-by: Jintu Das <[email protected]>

* Update CHANGELOG

Signed-off-by: Jintu Das <[email protected]>

* Change logger output to out instead of err

Signed-off-by: Jintu Das <[email protected]>

* move changelog entry to unreleased

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Jintu Das <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Co-authored-by: Justin Florentine <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants