Generalize state root computation future into a StateRootCommitter abstraction
#9373
+628
−335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Kovar <[email protected]>
Signed-off-by: Miroslav Kovar <[email protected]>
mirgee
force-pushed
the
state-root-committer
branch
from
3a423c2 to
39b05bd
Compare
matkt
reviewed
Oct 30, 2025
...c/main/java/org/hyperledger/besu/ethereum/trie/forest/worldview/ForestMutableWorldState.java
Show resolved
Hide resolved
evm/src/main/java/org/hyperledger/besu/evm/operation/AbstractCallOperation.java
Show resolved
Hide resolved
Signed-off-by: Miroslav Kovar <[email protected]>
…mitters Signed-off-by: Miroslav Kovar <[email protected]>
matkt
reviewed
Oct 31, 2025
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/MutableWorldState.java
Show resolved
Hide resolved
Signed-off-by: Miroslav Kovar <[email protected]>
matkt
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor replaces the
maybeStateRootFuturemechanism withStateRootCommitterabstraction with implementation dependent on whether BALs are enabled or not, simplifying the persistence and block processing logic.StateRootCommitterandStateRootCommitterFactoryinterfaces are introduced with default and BAL-aware implementations.StateRootCommitterFactory, defined by the currentProtocolSpec, creates a per-blockStateRootCommitter, optionally launching a state root computation future.BonsaiWorldState#persistthen delegates state root computation logic to the providedStateRootCommitter- either launching a synchronous state root computation or retrieving the pre-computed value.