feat: add Brave Search engine option

[joshuafhiggins]

For your pull request to not get closed without review, please confirm that:

• An issue exists where the maintainers agreed that this should be implemented.
  If such issue did not exist before, I opened one.
• I tested that my contribution works locally, and does not break anything,
  otherwise I have marked my PR as draft.
• If my contribution is non-trivial, I did not use AI to write most of it.
• I understand that I will be permanently banned from interacting with this
  organization if I lied by checking any of these checkboxes.

Tested on (check one or more):

• Windows
• macOS
• Linux

---

Adds the option to pick Brave Search as a default search engine. I'll work on a PR for onboarding to add it there too. Also would someone else be able to test that the favicon loads for them in settings? The URL in the source code for it is valid but something about it causes the following error when trying to show in settings: ERROR:third_party/blink/renderer/core/html/media/html_media_element.cc:5045] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"}

Needs update to nonfree gist for favicon and to helium-onboarding.

Dependent on #826 ✅

Resolves #92

[dumbmoron]

The URL in the source code for it is valid but something about it causes the following error when trying to show in settings: ERROR:third_party/blink/renderer/core/html/media/html_media_element.cc:5045] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"}

This is likely unrelated, but it would be nice if you could find out the root cause of it so we can (maybe) fix it.

[dumbmoron]

also FYI, as mentioned in #92 this is blocked by easylist/easylist#22543 until it gets merged in some capacity into EasyList (I thought it was already in EasyList, which is why I approved the issue, but I guess not..)

[joshuafhiggins]

The URL in the source code for it is valid but something about it causes the following error when trying to show in settings: ERROR:third_party/blink/renderer/core/html/media/html_media_element.cc:5045] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"}

This is likely unrelated, but it would be nice if you could find out the root cause of it so we can (maybe) fix it.

Google Chrome does load chrome://theme/IDR_SEARCH_ENGINE_BRAVE_IMAGE@2x fine. Is there somewhere I have to add cdn.search.brave.com in order to whitelist settings pages to be able to contact it? The developer console network tab will sometimes show the file request as "blocked:other" and when that happens ERROR:CONSOLE:0] "Not allowed to load local resource: chrome://theme/IDR_SEARCH_ENGINE_BRAVE_IMAGE@2x" is put in standard out all other times it's just "net::ERR_FAILED". This may be a completely wrong guess. Loading other chrome://theme/IDR_ search engines work fine though.

[dumbmoron]

It's likely missing from search_engines_data in extras.ini, so it will need to be added there

[joshuafhiggins]

It's likely missing from search_engines_data in extras.ini, so it will need to be added there

Ah I see, so it just needs to be added to the nonfree gist before this gets merged. I'll keep this as draft till the other PR merges into easylist and update this to latest when that time comes.

[Bellisario]

@joshuafhiggins the pull request on easylist has already been merged and it's live on uBlock Origin filters under the Fanboy's Annoyances list (easylist/easylist#22443)!

Only thing... I had to add the rule as (Fanboy) "annoyance", which is an optional (and disabled by default) filter list for uBlock Origin so it will never automatically be available in Helium without changing the lists enabled by default.

[sakhalif197]

i want this feature coming too

[dumbmoron]

easylist/easylist#22583