Skip to content

Conversation

@jesperbeisner
Copy link

Proposed Changes

Remove deprecation for implicitly nullable parameter types since php 8.4

Checklist

  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.09%. Comparing base (e9f4c54) to head (3d35540).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #161   +/-   ##
=========================================
  Coverage     75.09%   75.09%           
- Complexity      433      437    +4     
=========================================
  Files            25       25           
  Lines          1104     1104           
=========================================
  Hits            829      829           
  Misses          275      275           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesperbeisner
Copy link
Author

jesperbeisner commented Feb 19, 2025

@bednar Hey, could you maybe take a look at this? I really have no idea what the Codecov stuff is and don't wanna sign anything. Maybe you could implement and merge this yourself? This is flooding our deprecation logs and needs to be fixxed. 😿

Thank you very much! 😀

Source: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

@karel-rehor
Copy link
Contributor

@jesperbeisner

Jakub Bednar is on holiday this week, so I took your change and added it using a new branch and PR on our side (#164). This has just been merged. I'm looking to releasing this with another PR shortly.

@karel-rehor
Copy link
Contributor

#164 covers this change. Closing

@karel-rehor
Copy link
Contributor

@jesperbeisner
Copy link
Author

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants