Skip to content

Conversation

karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Feb 20, 2025

Replaces #161

Proposed Changes

Remove deprecation for implicitly nullable parameter types since php 8.4

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • make test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@karel-rehor karel-rehor requested a review from alespour February 20, 2025 12:44
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.09%. Comparing base (1b59d57) to head (6f6bc8f).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #164   +/-   ##
=========================================
  Coverage     75.09%   75.09%           
- Complexity      433      437    +4     
=========================================
  Files            25       25           
  Lines          1104     1104           
=========================================
  Hits            829      829           
  Misses          275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@alespour alespour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple change, tests pass -> LGTM

@karel-rehor karel-rehor merged commit 8111b4a into master Feb 20, 2025
12 checks passed
@karel-rehor karel-rehor deleted the fix/implicit-nullable-parameter-types branch February 20, 2025 13:02
@karel-rehor karel-rehor added this to the 3.7.0 milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants