-
Couldn't load subscription status.
- Fork 877
feat: support team organization role assignment #2322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support team organization role assignment #2322
Conversation
|
|
||
| randomID := acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum) | ||
|
|
||
| // Using the predefined roles since custom roles are a strictly Enterprise feature ((https://github.blog/changelog/2024-07-10-pre-defined-organization-roles-that-grant-access-to-all-repositories/)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since custom organization roles are a Enterprise level feature, I have elected to not use them in the tests and instead use the built-in roles instead. I've created a manual mapping for their role_id:s here. Not ideal, but I don't have a better way of testing this
|
Looking forward to this feature! Any thoughts on when it might be implemented? |
|
@ChristopherMank sometime after #2443 is merged probably. The bump of the SDK will include google/go-github#3281, which makes it possible to use the google/go-github sdk entirely for this PR instead of the octokit/go-sdk. I want to avoid using it because of the reason mentioned here. There are some minor changes required to this PR after that as well, but not difficult at all to do. |
…ion_role_assignment
|
@garettmd I'm not actively working on this. I think the latest update regarding Organization Roles support can be found in #2487. TLDR is that there are open PR:s for solving the issue, but we are lacking maintainer support for getting them over the line. The 2 latest updates to this repo (#2615, #2665) might offer some more context on that topic. |
|
Fast follow: #2787 |
Resolves #2314
Before the change?
After the change?
github_team_organization_role_assignmentresource which is used to assign an organization role to a teamPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!