feat: Added organization role support

[stevehipwell]

Resolves #2314
Resolves #2224

---

Before the change?

• No support for organization org roles

After the change?

• Added support for organization or roles
• Data sources
  • github_organization_repository_role
  • github_organization_repository_roles
  • github_organization_role
  • github_organization_role_teams
  • github_organization_users
  • github_organization_roles
  • github_organization_security_managers
• Resources
  • github_organization_repository_role
  • github_organization_role
  • github_organization_role_team
  • github_organization_role_user

Pull request checklist

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes
• No

---

[jtnz]

JFYI I think that this will conflict with github_repository_collaborators and will need a note in the docs to warn users.

I tried this out today (manually assigned an org role to a team) and on the next TF apply run it proceeded to spend the next ~45mins trying to remove the team from every repo in the organization. It finished happily (and with no actual affect), but the next run it does the same thing. I believe the problem is in the GH API. It mashes all team access together and offers no way to differentiate why the teams are in the list ("direct access" vs "organization access").

[stevehipwell]

@jtnz github_repository_collaborators has an input to allow it to not conflict with organization roles; the docs likely should belong on github_repository_collaborators (check out #2551 where these are already being updated). This is a GitHub issue and not provider related, due to the way the API works there isn't an easy way to filter org role users out at the repo level.

[jtnz]

@stevehipwell Haha, yeah, I just found this in 6.5.0. Thanks

[felixlut]

@stevehipwell are you still working on this? I've had this old PR open for a while, and it looks like there is some overlap here (my PR fixes organizational role team assignments).

[stevehipwell]

@felixlut I am still working on this, but given the scarcity of maintainer attention I've not rebased my PRs.

[nafisdev]

is there a way to expedite this. I need this ASAP. I have a workaround, but having tough time managing the states.

[istathar]

Hilariously, Google's Gemini AI keeps recommending that I use the github_team_organization_role resource because it read this PR and thinks that the ability to specify such a role assignment is a part of the GitHub Terraform provider.

(I find myself in a position to test this, if the maintainers need someone to check it against their real world use case. Let us know if we can be of any help to get this merged and released?)

[nafisdev]

just yesterday, i reached out to one of the maintainers and asked to expedite this. I hope they are reviewing it now.

[Bradley-McCallion]

Please let me know if there is any support needed on getting this merged, such a must for this terraform provider!

[deepsihag]

How can we get some traction on this? Seems like many are available to extend the support if needed.

[zlobober]

+1

Let me tag @kfcampbell as one of the mergers of recent pull requests. This feels like an important feature, could you please expedite this one?

[stevehipwell]

@nickfloyd should I take this as a sign to rebase my outstanding PRs or is this a one off?

[nickfloyd]

@stevehipwell I am actively working to get some much needed change sets merged in and eventually released. Given the age, nature, and variation of these changes I have some CI issues I need to get knocked out. Feel free to rebase but know I will not release until everything is completely stable and working as expected in main - including docs / coverage for any new feature support, which btw you did an amazing job with that on all of this - thank you!

[stevehipwell]

@nickfloyd have you looked at #2476? I worked through all of the tests to fix them, changes since the PR was last rebased likely need integrating.

[nickfloyd]

@nickfloyd have you looked at #2476? I worked through all of the tests to fix them, changes since the PR was last rebased likely need integrating.

I haven't just yet. I'm still trying to catch up on about a year of backlog 😬. I'll definitely add it to the priority list and see if I can help out. Any footwork you can do on it before hand while I am working on those dependent change sets would definitely be appreciated. Thank you again for all of the amazing hard work - I'll do my best to honor it.