test: ignore errors related to workflow screen recording #8683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the screen recordings are nice to have for forensics, but not an indicator of whether the test run itself is succeeding at same time screen recording setup apperas to fail 3-4% of the time and is now one of the most significant sources of flakiness, so continue if that's the only problem
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
not sure how this could be undefined but something caused it to crash in a CI run, avoiding the crash now. The test would fail in practice if it did not crash, and then potentially retry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the screen recordings are nice to have for forensics, but not an indicator of whether the test run itself is succeeding
at same time screen recording setup apperas to fail 3-4% of the time and is now one of the most significant sources of flakiness, so continue if that's the only problem
This should take our iOS CI flakiness down from approx 3/30 or 10% to approx 2/30 or 6-7%, a worthwhile win
Related issues
Release Summary
test only
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
it's all determined via iterative / flake-hammer style runs on iOS and Other, but here is the most recent example of this failure: https://github.com/invertase/react-native-firebase/actions/runs/17370625894/job/49305461304
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter