Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/tests_e2e_ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,13 @@ jobs:
steps:
- name: Setup Environment for Screen Recording
uses: guidepup/[email protected]
continue-on-error: true
with:
record: true

- name: Upload Screen Recording Environment Setup
uses: actions/upload-artifact@v4
continue-on-error: true
if: always()
with:
name: screenrecording-setup-${{ matrix.buildmode }}-${{ matrix.iteration }}.mov
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/tests_e2e_other.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,13 @@ jobs:
steps:
- name: Setup Environment for Screen Recording
uses: guidepup/[email protected]
continue-on-error: true
with:
record: true

- name: Upload Screen Recording Environment Setup
uses: actions/upload-artifact@v4
continue-on-error: true
if: always()
with:
name: screenrecording-setup-${{ matrix.iteration }}.mov
Expand Down Expand Up @@ -235,6 +237,7 @@ jobs:
echo "...javascript bundle ready"

- name: Start Screen Recording and System Logging
continue-on-error: true
run: |
nohup sh -c "sleep 314159265 | screencapture -v -C -k -T0 -g screenrecording.mov > screenrecording.log 2>&1 &"
nohup sh -c "log stream --backtrace --color none --style syslog > syslog.log 2>&1 &"
Expand Down
6 changes: 5 additions & 1 deletion packages/remote-config/e2e/config.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,11 @@ describe('remoteConfig()', function () {
if (!spy.called) return false;
for (let i = 0; i < spy.callCount; i++) {
const callbackEvent = spy.getCall(i).args[0];
if (callbackEvent.updatedKeys && callbackEvent.updatedKeys.includes(paramName)) {
if (
callbackEvent &&
callbackEvent.updatedKeys &&
callbackEvent.updatedKeys.includes(paramName)
) {
return true;
}
}
Expand Down
Loading