-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
AWTSettingsDialog: javadoc + add AppSettings Preference logging #2478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWTSettingsDialog: javadoc + add AppSettings Preference logging #2478
Conversation
|
Hi @yaRnMcDonuts , I have updated the class with the suggested changes. Thanks again for your feedback. |
|
I plan to merge this within the next few days; let me know if you want me to wait any longer. Thanks for your work on upgrading the appSetting interface with this PR! |
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
|
It looks like github made a mistake when generating the suggested code to solve the conflicts, and I fixed one thing but overlooked the other. For some reason, github removed 2 lines of code: one with an opening comment character: |
This PR focuses on a significant overhaul of the
AWTSettingsDialogclass, aiming to improve its maintainability, user experience, and overall stability.Key changes include:
Introduced
AppSettings.printPreferences()calls during both the loading and saving phases ofAppSettingswithin the dialog. This provides crucial visibility into the exact parameters being read from and written to the application's preference store, greatly aiding in debugging configuration issues.These changes collectively lead to a more reliable, well-documented, and user-friendly settings dialog for jMonkeyEngine applications, with improved insights into preference management.
Refactor AppSettings: Add Robust Getters and printPreferences Logging
This PR enhances the
AppSettingsclass by introducing more robust getter methods (getInteger,getBoolean,getString,getFloat) that now accept a default value for improved fault tolerance. Additionally, theprintPreferencesmethod has been added. These changes improve the usability and reliability of theAppSettingsconfiguration system.e.g.