Link to genuine pull requests from README examples #2217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
webknjaz
reviewed
Aug 4, 2025
|
@jayaddison could you rebase instead of pushing merge commits into the topic branch? |
webknjaz
reviewed
Aug 19, 2025
Will do on next push; thanks 👍 |
The migration to towncrier in jazzband#2203 included a couple of synthetic change note examples. Now that towncrier is in use and some changes that use it have landed in pip-tools, we can update the examples so that they hyperlink to genuine pull requests. This is intended to aid contributors by providing them with more accurate, representative examples to crib from.
Relates-to commit 1a8cbcc. Closes jazzband#2240
jayaddison
force-pushed
the
pr-2203-followup/reify-changenote-examples
branch
from
924199c to
e7e2673
Compare
sirosen
approved these changes
Sep 26, 2025
|
Thanks again @sirosen! |
jayaddison
added a commit
to openculinary/pip-tools
that referenced
this pull request
Sep 26, 2025
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
…elog-entry Add changelog entry for #2217
webknjaz
reviewed
Sep 26, 2025
| soupsieve==2.4.1 | ||
| # via beautifulsoup4 | ||
| sphinx==7.2.2 | ||
| sphinx==7.2.6 |
There was a problem hiding this comment.
This should've been bumped separately. There's no evidence of Sphinx breaking in CI/RTD: https://app.readthedocs.org/projects/pip-tools/builds/. And it's unrelated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migration to towncrier in #2203 included a couple of synthetic change note examples.
Now that
towncrieris in use and some changes that use itare soon to landhave landed inpip-tools, we can update the examples so that they hyperlink to genuine pull requests.This is intended to aid contributors by providing them with more accurate, representative examples to crib from.
No changelog needed.
Contributor checklist
Included tests for the changes.A change note is created inor the PR text says "no changelog needed".changelog.d/(seechangelog.d/README.mdfor instructions)Maintainer checklist
skip-changeloglabel.Additional fixes
Two problems encountered while testing this are currently resolved by this branch: