-
-
Notifications
You must be signed in to change notification settings - Fork 633
Link to genuine pull requests from README examples #2217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c53dddf
718905e
ec9ec94
1a8cbcc
5fcdaf2
e7e2673
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| `pip-tools` now tests on and officially supports `pip` version 25.2 -- by :user:`sirosen`. | ||
| `pip-tools` now tests on and officially supports `pip` version 25.2 -- by {user}`sirosen`. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| Fix an incompatibility with ``click >= 8.3`` which made ``pip-compile`` display incorrect | ||
| options in the compile command in output headers -- by :user:`sirosen`. | ||
| options in the compile command in output headers -- by {user}`sirosen`. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,19 +62,17 @@ Do your best and a maintainer can discuss this with you during review. | |
|
|
||
| ### Examples | ||
|
|
||
| Example bugfix, `2082.bugfix.md`: | ||
| Example bugfix, [`2223.bugfix.md`](https://github.com/jazzband/pip-tools/pull/2224): | ||
|
|
||
| ```md | ||
| Fixed the ordering of format controls to preserve underlying `pip` behavior | ||
| -- by {user}`sethmlarson`. | ||
| Fixed a bug which removed slashes from URLs in ``-r`` and ``-c`` in the output | ||
| of ``pip-compile`` -- by {user}`sirosen`. | ||
|
Comment on lines
+68
to
+69
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jayaddison the double backticks should've been fixed here. We missed this in review. |
||
| ``` | ||
|
|
||
| Example contributor update, `2202.contrib.md`: | ||
| Example contributor update, [`2214.contrib.md`](https://github.com/jazzband/pip-tools/pull/2214): | ||
|
|
||
| ```md | ||
| `pip-tools` now uses [`sphinx-issues`](https://github.com/sloria/sphinx-issues) | ||
| to link to issues, PRs, commits, and user accounts | ||
| -- by {user}`sirosen`. | ||
| `pip-tools` now tests on and officially supports `pip` version 25.2 -- by {user}`sirosen`. | ||
| ``` | ||
|
|
||
| ### Rationale | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,7 +72,7 @@ snowballstemmer==2.2.0 | |
| # via sphinx | ||
| soupsieve==2.4.1 | ||
| # via beautifulsoup4 | ||
| sphinx==7.2.2 | ||
| sphinx==7.2.6 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should've been bumped separately. There's no evidence of Sphinx breaking in CI/RTD: https://app.readthedocs.org/projects/pip-tools/builds/. And it's unrelated. |
||
| # via | ||
| # -r docs/requirements.in | ||
| # furo | ||
|
|
@@ -105,7 +105,7 @@ sphinxcontrib-programoutput==0.17 | |
| # via -r docs/requirements.in | ||
| sphinxcontrib-qthelp==1.0.6 | ||
| # via sphinx | ||
| sphinxcontrib-serializinghtml==1.1.8 | ||
| sphinxcontrib-serializinghtml==1.1.10 | ||
| # via sphinx | ||
| sphinxcontrib-towncrier==0.5.0a0 | ||
| # via -r docs/requirements.in | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jayaddison the double backticks should've been fixed here. We missed this in review.