-
Notifications
You must be signed in to change notification settings - Fork 18
[SBA-02] update typescript and add typecheck script #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c5ce3a6 to
36e49c3
Compare
4878338 to
a0489fb
Compare
jbrill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit -- otherwise approved
a0489fb to
923919f
Compare
jamaljsr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbrill Thanks for reviewing. I've made the change requested.
jbrill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK LGTM 👍
yarn run v1.22.22
(node:43418) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities.
(Use `node --trace-deprecation ...` to show where the warning was created)
$ tsc --noEmit --project tsconfig.typecheck.json
✨ Done in 1.05s
923919f to
97ea2d2
Compare
Summary
This is another preparatory PR in the Session-based Auth saga, which updates
typescriptto use the latest version.I've also added an explicit
yarn typecheckcommand to ensure the TS code is valid via the CLI.Technical Notes
In order to include the unit tests in the type checking, but exclude it from the build output, I needed to introduce an additional
tsconfigfile. This is used only for type checking and it includes*.test.tsfiles and thetestdir. The defaulttsconfig.jsonfile is used for the webpack build and this excludes the tests.Steps to Test
yarn installyarn typecheckRelated Issues & Pull Requests
Depends on: