Skip to content

Conversation

@jamaljsr
Copy link
Member

@jamaljsr jamaljsr commented Nov 19, 2025

Summary

This is another preparatory PR in the Session-based Auth saga, which updates typescript to use the latest version.

I've also added an explicit yarn typecheck command to ensure the TS code is valid via the CLI.

Technical Notes

In order to include the unit tests in the type checking, but exclude it from the build output, I needed to introduce an additional tsconfig file. This is used only for type checking and it includes *.test.ts files and the test dir. The default tsconfig.json file is used for the webpack build and this excludes the tests.

Steps to Test

  1. Update dependencies with yarn install
  2. Check the types with yarn typecheck

Related Issues & Pull Requests

Depends on:

Copy link

@jbrill jbrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit -- otherwise approved

Copy link
Member Author

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbrill Thanks for reviewing. I've made the change requested.

@jamaljsr jamaljsr requested a review from jbrill November 24, 2025 20:04
Copy link

@jbrill jbrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 👍

yarn run v1.22.22
(node:43418) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities.
(Use `node --trace-deprecation ...` to show where the warning was created)
$ tsc --noEmit --project tsconfig.typecheck.json
✨  Done in 1.05s

Base automatically changed from auth-01-indent to main November 25, 2025 00:51
@jamaljsr jamaljsr merged commit 40b29ec into main Nov 25, 2025
6 checks passed
@jamaljsr jamaljsr deleted the auth-02-config branch November 25, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants