Add new RPCs introduced in lnd v0.18.4 #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 18, 2024
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
5e064ba to
710c190
Compare
To avoid needing to wait a full 5 seconds to re-try checking lnd's status, we allow passing in a custom poll interval. This significantly speeds up some integration tests.
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
710c190 to
9ce031b
Compare
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
9ce031b to
5bc7b3f
Compare
This was referenced Sep 19, 2024
With the latest lnd master versioned as v0.18.99-beta, we can now require this commit of lndclient to require a minimum version of v0.18.4-beta (which will ship all the RPC changes in this PR).
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
5bc7b3f to
ac30126
Compare
ffranr
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the client to expose all new RPCs added for the custom channel functionality with
lnd 0.18.4-beta.EDIT: Since part 4 was merged into
masterand the version ofmasterbumped tov0.18.99-beta, we can now go ahead and merge this PR into thelnd-18-4branch.Pull Request Checklist
in
lnd_services.goare updated.macaroon_recipes.goif your PR adds a new method that is calleddifferently than the RPC method it invokes.