cmd/loop: update urfave/cli to v3, auto-generate loop CLI reference manual and man file #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starius
force-pushed
the
urfave-cli-updates
branch
from
ae27cf6 to
f928b4f
Compare
sputn1ck
approved these changes
Oct 7, 2025
| autoloop timer. THIS MUST NOT BE USED IN A PROD ENVIRONMENT. | ||
| `, | ||
| Action: forceAutoloop, | ||
| Hidden: true, |
There was a problem hiding this comment.
This command is already hidden behind the dev build flag, but nothing wrong with adding extra hidden flag.
There was a problem hiding this comment.
The man and the markdown are built using loop-debug binary built by make build. That target builds with "dev" tag.
It is not intended for prod use. Those who need it can still use it.
urfave/cli/v3 returns "" if an int flag is accessed using String getter.
urfave/cli/v3 returns "" if an int flag is accessed using String getter.
Previously it was parsed as a single JSON string. Now each hint is parsed individually.
Previous version validated the value of non-existent flag "static-loop-in". The value passed to loopd was correct though.
starius
force-pushed
the
urfave-cli-updates
branch
from
f928b4f to
71b62c0
Compare
|
Rebased |
starius
force-pushed
the
urfave-cli-updates
branch
from
71b62c0 to
ab8ea4a
Compare
|
Updated static loop in usage: Updated docs for |
starius
force-pushed
the
urfave-cli-updates
branch
2 times, most recently
from
3f2d803 to
eac8e7b
Compare
Produce the documentations in man .1 and markdown formats. The template for markdown was patched to removed column "Environment variables" Upstream PR: urfave/cli-docs#15 Also the input has to be pre-processed to remove nested "help" subcommands from each subcommand to improve readability. Upstream PR: urfave/cli-docs#16
starius
force-pushed
the
urfave-cli-updates
branch
from
eac8e7b to
9eddee7
Compare
|
Fixed documentation generation to put paths like CI was catching this with diffs like this: -\fB--loopdir\fP="": path to loop's base directory (default: /home/user/.loop)
+\fB--loopdir\fP="": path to loop's base directory (default: /home/runner/.loop) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
urfave/cli/v3, adjusted every command/action to the new APIloop man/loop markdownhelpers plus Make/Ci steps that regenerate manpages/markdown and verify docs stay up to date.forceautoloopcommand from end users.Testing
make buildloop manloop markdownmake docs-checkloopto make sure it works properly