Fix test pollution in RoomServiceClientTest #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This the createRoom test would fail if run after updateMetadata since createRoom doesn't seem to fail if the room already exists but also doesn't overwrite the metadata. I fixed the test to create a new room for each test and also clean it up after.
Unfortunately these tests don't run in CLI due to the dependency on livekit-server so this failure wasn't caught, but also it's not a real bug just a broken test.