Skip to content

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented May 20, 2025

This the createRoom test would fail if run after updateMetadata since createRoom doesn't seem to fail if the room already exists but also doesn't overwrite the metadata. I fixed the test to create a new room for each test and also clean it up after.

Unfortunately these tests don't run in CLI due to the dependency on livekit-server so this failure wasn't caught, but also it's not a real bug just a broken test.

@bcherry bcherry requested review from davidliu and anunaym14 May 20, 2025 00:15
Copy link

changeset-bot bot commented May 20, 2025

⚠️ No Changeset found

Latest commit: 626f8b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bcherry bcherry merged commit d61ebca into main May 20, 2025
4 checks passed
@bcherry bcherry deleted the bcherry/room-service-test-pollution branch May 20, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants