Skip to content

Fix test pollution in RoomServiceClientTest #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

Fix test pollution in RoomServiceClientTest #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 35 additions & 22 deletions src/test/kotlin/io/livekit/server/RoomServiceClientTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2024 LiveKit, Inc.
* Copyright 2024-2025 LiveKit, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -18,6 +18,8 @@ package io.livekit.server

import io.livekit.server.okhttp.OkHttpFactory
import livekit.LivekitModels
import java.util.UUID
import kotlin.test.AfterTest
import kotlin.test.BeforeTest
import kotlin.test.Ignore
import kotlin.test.Test
Expand All @@ -31,59 +33,68 @@ class RoomServiceClientTest {
const val HOST = TestConstants.HOST
const val KEY = TestConstants.KEY
const val SECRET = TestConstants.SECRET

const val ROOM_NAME = "room_name"
const val METADATA = "metadata"
}

lateinit var client: RoomServiceClient
lateinit var roomName: String

@BeforeTest
fun setup() {
client = RoomServiceClient.createClient(HOST, KEY, SECRET, OkHttpFactory(true, null))
roomName = "test_room_${UUID.randomUUID()}"
}

@AfterTest
fun cleanup() {
try {
client.deleteRoom(roomName).execute()
} catch (e: Exception) {
// Ignore cleanup errors
}
}

@Test
fun createRoom() {
val metadata = "metadata"
val response = client.createRoom(
name = ROOM_NAME,
metadata = METADATA,
name = roomName,
metadata = metadata,
).execute()
val room = response.body()

assertTrue(response.isSuccessful)
assertEquals(ROOM_NAME, room?.name)
assertEquals(METADATA, room?.metadata)
assertEquals(roomName, room?.name)
assertEquals(metadata, room?.metadata)
}

@Test
fun listRooms() {
client.createRoom(ROOM_NAME).execute()
client.createRoom(roomName).execute()
val response = client.listRooms(null).execute()
val rooms = response.body()

assertTrue(response.isSuccessful)
assertNotNull(rooms)
assertTrue(rooms.any { room -> room.name == ROOM_NAME })
assertTrue(rooms.any { room -> room.name == roomName })
}

@Test
fun deleteRoom() {
client.createRoom(ROOM_NAME).execute()
client.deleteRoom(ROOM_NAME).execute()
client.createRoom(roomName).execute()
client.deleteRoom(roomName).execute()
val response = client.listRooms(null).execute()
val rooms = response.body()

assertTrue(response.isSuccessful)
assertNotNull(rooms)
assertTrue(rooms.none { room -> room.name == ROOM_NAME })
assertTrue(rooms.none { room -> room.name == roomName })
}

@Test
fun updateRoomMetadata() {
val metadata = "NewMetadata"
client.createRoom(ROOM_NAME).execute()
val response = client.updateRoomMetadata(ROOM_NAME, metadata).execute()
client.createRoom(roomName).execute()
val response = client.updateRoomMetadata(roomName, metadata).execute()
val room = response.body()

assertTrue(response.isSuccessful)
Expand All @@ -93,8 +104,8 @@ class RoomServiceClientTest {

@Test
fun listParticipants() {
client.createRoom(ROOM_NAME).execute()
val response = client.listParticipants(ROOM_NAME).execute()
client.createRoom(roomName).execute()
val response = client.listParticipants(roomName).execute()
val participants = response.body()
assertTrue(response.isSuccessful)
assertNotNull(participants)
Expand All @@ -104,12 +115,13 @@ class RoomServiceClientTest {
@Test
@Ignore("Requires manual participant")
fun updateParticipant() {
val participants = client.listParticipants(ROOM_NAME).execute().body()
client.createRoom(roomName).execute()
val participants = client.listParticipants(roomName).execute().body()
if (participants != null) {
val participant = participants.first()

val newMetadata = "new_metadata"
val response = client.updateParticipant(ROOM_NAME, participant.identity, metadata = newMetadata).execute()
val response = client.updateParticipant(roomName, participant.identity, metadata = newMetadata).execute()
val updatedParticipant = response.body()!!
assertTrue(response.isSuccessful)
assertEquals(newMetadata, updatedParticipant.metadata)
Expand All @@ -118,13 +130,14 @@ class RoomServiceClientTest {

@Test
fun getParticipant() {
val response = client.getParticipant(ROOM_NAME, "fdsa").execute()
client.createRoom(roomName).execute()
client.getParticipant(roomName, "fdsa").execute()
}

@Test
fun sendData() {
client.createRoom(ROOM_NAME).execute()
val response = client.sendData(ROOM_NAME, "data".toByteArray(), LivekitModels.DataPacket.Kind.RELIABLE).execute()
client.createRoom(roomName).execute()
val response = client.sendData(roomName, "data".toByteArray(), LivekitModels.DataPacket.Kind.RELIABLE).execute()
assertTrue(response.isSuccessful)
}
}