Skip to content

Fix a few shellcheck warnings in sanitizer buildbot script #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2024
Merged

Fix a few shellcheck warnings in sanitizer buildbot script #298

merged 2 commits into from
Nov 8, 2024

Conversation

@arichardson
Copy link
Member

@arichardson arichardson commented Nov 7, 2024 •
edited
Loading

No description provided.

@arichardson
[𝘀𝗽𝗿] initial version
b042560 
Created using spr 1.3.6-beta.1
@arichardson
rebase
2ed43cd 
Created using spr 1.3.6-beta.1
asb
asb approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@asb asb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All standard stuff, LGTM. The output of du -hs will change slightly (it will include the ./ prefix) but it seems it's not parsed directly in this script anyway.

@arichardson arichardson merged commit 0397cb6 into main Nov 8, 2024
3 checks passed
@arichardson arichardson deleted the users/arichardson/spr/fix-a-few-shellcheck-warnings-in-sanitizer-buildbot-script branch November 8, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asb asb asb approved these changes

@vitalybuka vitalybuka Awaiting requested review from vitalybuka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arichardson @asb