Skip to content

Fix a few shellcheck warnings in sanitizer buildbot script #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Fix a few shellcheck warnings in sanitizer buildbot script #298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b042560
[𝘀𝗽𝗿] initial version
arichardson Nov 7, 2024
2ed43cd
rebase
arichardson Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions zorg/buildbot/builders/sanitizers/buildbot_functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function cmake() {
}

function rm_dirs {
while ! rm -rf $@ ; do sleep 1; done
while ! rm -rf "$@" ; do sleep 1; done
}

function cleanup() {
Expand All @@ -94,7 +94,7 @@ function cleanup() {
fi
# Workaround the case when a new unittest was reverted, but incremental build continues to execute the leftover binary.
find -path ./llvm-project -prune -o -executable -type f -path '*unittests*' -print -exec rm -f {} \;
du -hs * | sort -h
du -hs ./* | sort -h
}

function clobber {
Expand All @@ -104,9 +104,9 @@ function clobber {
echo "Clobbering is supported only on buildbot only!"
exit 1
fi
rm_dirs *
rm_dirs ./*
else
BUILDBOT_BUILDERNAME=1 cleanup $@
BUILDBOT_BUILDERNAME=1 cleanup "$@"
fi
}

Expand Down Expand Up @@ -204,7 +204,7 @@ function build_clang_at_release_tag {
then
echo "@@@BUILD_STEP using pre-built stage1 clang at r${host_clang_revision}@@@"
else
BUILDBOT_MONO_REPO_PATH= BUILDBOT_REVISION="${host_clang_revision}" buildbot_update
BUILDBOT_MONO_REPO_PATH="" BUILDBOT_REVISION="${host_clang_revision}" buildbot_update

rm -rf ${STAGE1_DIR}
echo @@@BUILD_STEP build stage1 clang at $host_clang_revision@@@
Expand Down