Make it possible for users to disable .torchxconfig #1125
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Sep 24, 2025
Summary: So that the one below is valid and does not use any configs ``` TORCHXCONFIG="" torchx run ``` Differential Revision: D83086473
AbishekS
force-pushed
the
export-D83086473
branch
from
2806f30 to
23446f9
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Sep 24, 2025
Summary: So that the one below is valid and does not use any configs ``` TORCHXCONFIG="" torchx run ``` Differential Revision: D83086473
AbishekS
force-pushed
the
export-D83086473
branch
from
23446f9 to
eed1b8e
Compare
kiukchung
approved these changes
Sep 25, 2025
@kiukchung To retry the tests that are on github, I cant seem to find the retry action for it. Is it something that requires other perms somewhere? Or should i simply rebase and retry? |
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Sep 25, 2025
Summary: X-link: meta-pytorch#1125 So that the one below is valid and does not use any configs ``` TORCHXCONFIG="" torchx run ``` Reviewed By: kiukchung Differential Revision: D83086473
AbishekS
force-pushed
the
export-D83086473
branch
from
eed1b8e to
185d049
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1125 +/- ##
=======================================
Coverage 91.63% 91.63%
=======================================
Files 83 83
Lines 6392 6394 +2
=======================================
+ Hits 5857 5859 +2
Misses 535 535
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Sep 25, 2025
Summary: X-link: meta-pytorch#1125 So that the one below is valid and does not use any configs ``` TORCHXCONFIG="" torchx run ``` Reviewed By: kiukchung Differential Revision: D83086473
AbishekS
force-pushed
the
export-D83086473
branch
from
185d049 to
67e6fcf
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Sep 26, 2025
Summary: X-link: meta-pytorch#1125 So that the one below is valid and does not use any configs ``` TORCHXCONFIG="" torchx run ``` Reviewed By: kiukchung Differential Revision: D83086473
AbishekS
force-pushed
the
export-D83086473
branch
from
67e6fcf to
6351f7e
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Sep 26, 2025
Summary: X-link: meta-pytorch#1125 So that the one below is valid and does not use any configs ``` TORCHXCONFIG="" torchx run ``` Reviewed By: kiukchung Differential Revision: D83086473
AbishekS
force-pushed
the
export-D83086473
branch
from
6351f7e to
26bd3a8
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Sep 29, 2025
Summary: X-link: meta-pytorch#1125 So that the one below is valid and does not use any configs ``` TORCHXCONFIG="" torchx run ``` Reviewed By: kiukchung Differential Revision: D83086473
AbishekS
force-pushed
the
export-D83086473
branch
from
26bd3a8 to
8a64558
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Sep 29, 2025
Summary: X-link: meta-pytorch#1125 So that the one below is valid and does not use any configs ``` TORCHXCONFIG="" torchx run ``` Reviewed By: kiukchung Differential Revision: D83086473
AbishekS
force-pushed
the
export-D83086473
branch
from
8a64558 to
594bbfa
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Sep 29, 2025
Summary: X-link: meta-pytorch#1125 So that the one below is valid and does not use any configs ``` TORCHXCONFIG="" torchx run ``` Reviewed By: kiukchung Differential Revision: D83086473
AbishekS
force-pushed
the
export-D83086473
branch
from
594bbfa to
58a5573
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Sep 29, 2025
Summary: X-link: meta-pytorch#1125 So that the one below is valid and does not use any configs ``` TORCHXCONFIG="" torchx run ``` Reviewed By: kiukchung Differential Revision: D83086473
AbishekS
force-pushed
the
export-D83086473
branch
from
58a5573 to
ad922d9
Compare
Summary: X-link: meta-pytorch#1125 So that the one below is valid and does not use any configs ``` TORCHXCONFIG="" torchx run ``` Reviewed By: kiukchung Differential Revision: D83086473
AbishekS
force-pushed
the
export-D83086473
branch
from
ad922d9 to
bd26e93
Compare
facebook-github-bot
merged commit dc79474
into
meta-pytorch:main
19 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
So that the one below is valid and does not use any configs
Differential Revision: D83086473