Skip to content

Make it possible for users to disable .torchxconfig #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
Merged

Make it possible for users to disable .torchxconfig #1125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions torchx/runner/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,8 @@ def find_configs(dirs: Optional[Iterable[str]] = None) -> List[str]:

config = os.getenv(ENV_TORCHXCONFIG)
if config is not None:
if not config:
return []
configfile = Path(config)
if not configfile.is_file():
raise FileNotFoundError(
Expand Down
6 changes: 6 additions & 0 deletions torchx/runner/test/config_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,12 @@ def test_get_configs(self) -> None:
),
)

def test_no_config(self) -> None:
config_dir = self.tmpdir
with patch.dict(os.environ, {ENV_TORCHXCONFIG: str("")}):
configs = find_configs(dirs=[str(config_dir)])
self.assertEqual([], configs)

def test_find_configs(self) -> None:
config_dir = self.tmpdir
cwd_dir = config_dir / "cwd"
Expand Down
Loading