fix: move GetLanguageService to async closure to prevent dispatch loop blocking#3016
Closed
SibtainOcn wants to merge 3 commits intomicrosoft:mainfrom
Closed
fix: move GetLanguageService to async closure to prevent dispatch loop blocking#3016SibtainOcn wants to merge 3 commits intomicrosoft:mainfrom
SibtainOcn wants to merge 3 commits intomicrosoft:mainfrom
Conversation
…p blocking Fixes #2857 The formatter gets stuck because GetLanguageService runs synchronously on the dispatch loop thread and blocks on snapshotUpdateMu. When this mutex is held by another operation (e.g. DidOpenFile, idle cache clean timer, or concurrent snapshot updates), the dispatch loop stalls and no responses can be sent. This is most visible with format-on-save, since the save notification triggers snapshot updates that compete for the same lock the formatting handler needs. Moving GetLanguageService into the async closure allows the dispatch loop to remain responsive while the language service is being acquired in a goroutine.
Member
|
Does this not just undo #2765? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.