Skip to content

fix: move GetLanguageService to async closure to prevent dispatch loop blocking #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SibtainOcn wants to merge 3 commits into from
Closed

fix: move GetLanguageService to async closure to prevent dispatch loop blocking #3016

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6786119
fix: move GetLanguageService to async closure to prevent dispatch loo…
SibtainOcn Mar 7, 2026
6ddb097
Merge branch 'main' into fix/formatter-stuck-dispatch-loop-blocking
SibtainOcn Mar 8, 2026
f5efdf4
Merge branch 'main' into fix/formatter-stuck-dispatch-loop-blocking
SibtainOcn Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions internal/lsp/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,12 +741,17 @@ func registerLanguageServiceDocumentRequestHandler[Req lsproto.HasTextDocumentUR
if req.Params != nil {
params = req.Params.(Req)
}
ls, err := s.session.GetLanguageService(ctx, params.TextDocumentURI())
if err != nil {
return nil, err
}
// GetLanguageService is moved into the async closure to avoid blocking the
// dispatch loop. Previously, acquiring the language service synchronously could
// block on snapshotUpdateMu if another operation (e.g. DidOpenFile, idle cache
// clean, or a concurrent snapshot update) was holding the lock, causing the
// dispatch loop to stall and preventing responses from being sent. See #2857.
return func() error {
defer s.recover(req)
ls, err := s.session.GetLanguageService(ctx, params.TextDocumentURI())
if err != nil {
return err
}
resp, lsErr := fn(s, ctx, ls, params)
if lsErr != nil {
return lsErr
Expand Down