refactor: standardize test parameterization and fix package naming #556
+134
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemicL
requested changes
Sep 16, 2025
| @@ -45,6 +48,10 @@ class WebFluxSseIntegrationTests extends AbstractMcpClientServerIntegrationTests | |||
| static McpTransportContextExtractor<ServerRequest> TEST_CONTEXT_EXTRACTOR = (r) -> McpTransportContext | |||
| .create(Map.of("important", "value")); | |||
|
|
|||
| static Stream<Arguments> getTestParameters() { | |||
There was a problem hiding this comment.
Consider a more concrete name, like "clientsForTesting".
| @@ -16,6 +18,9 @@ | |||
| import org.springframework.web.servlet.function.RouterFunction; | |||
| import org.springframework.web.servlet.function.ServerResponse; | |||
|
|
|||
| import java.util.stream.Stream; | |||
|
|
|||
| import io.modelcontextprotocol.server.transport.WebFluxSseServerTransportProvider; | |||
There was a problem hiding this comment.
Here and potentially in other places there are some undesired imports like this one.
- Replace @valuesource with @MethodSource for parameterized tests - Add clientsForTesting() methods to provide test arguments consistently - Remove hardcoded Spring-related labels from framework-agnostic mcp-test module - Move mcp-test's utility classes from io.modelcontextprotocol.utils to io.modelcontextprotocol.util Signed-off-by: Christian Tzolov <[email protected]>
Signed-off-by: Christian Tzolov <[email protected]>
tzolov
force-pushed
the
improve-mcp-test-structure
branch
from
e70da86 to
cab0f01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.