Skip to content

Conversation

@mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented Jun 4, 2025

Description

the patch allows compilation with both qt5 and qt6

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@rhaschke
Copy link
Contributor

rhaschke commented Jun 4, 2025

Is this a backport of moveit/moveit#3582? If so, why didn't you declare it like this?
If not, why not? The PR was already reviewed and we should not do work twice.

@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (760277f) to head (60c7394).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #3493       +/-   ##
==========================================
- Coverage   46.19%   0.00%   -46.18%     
==========================================
  Files         720     571      -149     
  Lines       59181   51817     -7364     
  Branches     7594    6751      -843     
==========================================
- Hits        27333       0    -27333     
- Misses      31681   51817    +20136     
+ Partials      167       0      -167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

Fixed a rviz_default_plugin compilation error when using qt6.
The error is silent if you have qt5 and qt6 installed

fix qt6 compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants