Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Jun 5, 2025

Description

The normal state validation service is not very fast if you want to check a lot of joint states. This is significantly faster.

Requires moveit/moveit_msgs#186

Please could this be backported to humble

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3426 done by [Mergify](https://mergify.com).

Co-authored-by: Tom Noble <[email protected]>
Co-authored-by: Mark Johnson <[email protected]>
(cherry picked from commit fb34bff)

# Conflicts:
#	moveit_ros/move_group/CMakeLists.txt
#	moveit_ros/move_group/include/moveit/move_group/capability_names.hpp
#	moveit_ros/move_group/src/default_capabilities/state_validation_service_capability.cpp
@mergify mergify bot added the conflicts label Jun 5, 2025
@mergify
Copy link
Author

mergify bot commented Jun 5, 2025

Cherry-pick of fb34bff has failed:

On branch mergify/bp/humble/pr-3426
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit fb34bff59.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   moveit_ros/move_group/default_capabilities_plugin_description.xml
	new file:   moveit_ros/move_group/src/default_capabilities/multi_state_validation_service_capability.cpp
	new file:   moveit_ros/move_group/src/default_capabilities/multi_state_validation_service_capability.hpp
	modified:   moveit_ros/move_group/src/default_capabilities/state_validation_service_capability.h

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   moveit_ros/move_group/CMakeLists.txt
	deleted by us:   moveit_ros/move_group/include/moveit/move_group/capability_names.hpp
	both modified:   moveit_ros/move_group/src/default_capabilities/state_validation_service_capability.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions
Copy link

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Jul 23, 2025
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (3f2d7f5) to head (73beb74).

Additional details and impacted files
@@            Coverage Diff             @@
##           humble   #3495       +/-   ##
==========================================
- Coverage   50.95%       0   -50.94%     
==========================================
  Files         390       0      -390     
  Lines       32521       0    -32521     
==========================================
- Hits        16567       0    -16567     
+ Misses      15954       0    -15954     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts stale Inactive issues and PRs are marked as stale and may be closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants