Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Jun 5, 2025

Description

The normal state validation service is not very fast if you want to check a lot of joint states. This is significantly faster.

Requires moveit/moveit_msgs#186

Please could this be backported to humble

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3426 done by [Mergify](https://mergify.com).

Co-authored-by: Tom Noble <[email protected]>
Co-authored-by: Mark Johnson <[email protected]>
(cherry picked from commit fb34bff)
@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 2.22222% with 44 lines in your changes missing coverage. Please review.

Project coverage is 46.22%. Comparing base (e489b04) to head (a4ddd5a).

Files with missing lines Patch % Lines
...pabilities/state_validation_service_capability.cpp 0.00% 26 Missing ⚠️
...ties/multi_state_validation_service_capability.cpp 5.56% 17 Missing ⚠️
...ties/multi_state_validation_service_capability.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3496      +/-   ##
==========================================
+ Coverage   46.21%   46.22%   +0.02%     
==========================================
  Files         718      720       +2     
  Lines       62675    62693      +18     
  Branches     7589     7591       +2     
==========================================
+ Hits        28957    28975      +18     
+ Misses      33554    33553       -1     
- Partials      164      165       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Jul 23, 2025
@riv-ljames
Copy link
Contributor

@sjahr Can this be approved and merged?

@github-actions github-actions bot removed the stale label Oct 8, 2025
@riv-mjohnson
Copy link
Contributor

I've just realised that sjahr is now listed as an inactive maintainer on https://moveit.ai/about/

Could an active maintainer approve and merge this, when you get time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants