ci: improve build matrix configuration, test with python3.13 and neovim-stable as well #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem 1: Dynamic matrix configuration using matrix.{include,exclude}
is complicated, making it difficult to add a few additional matrix
configurations. For example, if we wanted to add a new axis in the
matrix configuration that should be enabled only for specific configs
(e.g., neovim stable vs. nightly only for python-version='3.12'), we
would need to write long lines of include or exclude rules, which are
quite difficult to read.
Solution 1: Avoid using matrix.include and matrix.exclude, and specify
runner OS version paired with python-version. The runner OS version can
be simply determined by reading the associative array `matrix.config`
with the platform-specific key.
Problem 2: macos-12 has been deprecated and can no longer be run.
Solution 2: Switch to macos-13 runner for old python versions.
- Test with python=3.13 - Test with neovim-version='stable' for python=3.12 in addition to neovim-version='nightly'.
The fix made in neovim#570 actually works for Nvim 0.11+, depending on the behavior change neovim/neovim#28487. We should just skip test_broadcast on older Nvim versions (see neovim#585).
wookayin
commented
Jan 7, 2025
justinmk
approved these changes
Jan 7, 2025
wookayin
added a commit
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Tests are still failing on nvim-nightly due to upstream bug, but as soon as neovim/neovim#31894 is fixed CI should be back to green.