Skip to content

Topic migration dedup#10814

Closed
isgenome wants to merge 2 commits intonf-core:masterfrom
isgenome:dedup
Closed

Topic migration dedup#10814
isgenome wants to merge 2 commits intonf-core:masterfrom
isgenome:dedup

Conversation

@isgenome
Copy link
Contributor

@isgenome isgenome commented Mar 13, 2026

PR checklist

Closes #10756

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@isgenome isgenome self-assigned this Mar 13, 2026
@isgenome isgenome marked this pull request as ready for review March 13, 2026 10:59
@isgenome isgenome enabled auto-merge March 13, 2026 11:16
@mahesh-panchal
Copy link
Member

Hi. Thank you for making the PR.
However there don't appear to be any changes other than the timestamp and version updates to the snapshot. The PR is missing changes the module showing the conversion to a topic channel.

@LouisLeNezet LouisLeNezet disabled auto-merge March 15, 2026 18:13
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contains no actual changes at the moment.

@isgenome isgenome removed their assignment Mar 17, 2026
@mahesh-panchal
Copy link
Member

@isgenome If you're not planning to continue work on this pull request, please close it.

@isgenome isgenome closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration to topics channels: dedup

3 participants