Migration to topics channels: diamond/blastp #10766#10885
Migration to topics channels: diamond/blastp #10766#10885LorenzoCampanelli1102 wants to merge 7 commits intonf-core:masterfrom
Conversation
mantisps
left a comment
There was a problem hiding this comment.
Please check why the version captured is not the correct one. I believe the change you did on the version command affected something.
| "DIAMOND_BLASTP", | ||
| "diamond", | ||
| "2.1.23" | ||
| "2.1.16" |
There was a problem hiding this comment.
There is something weird here.. The version number is not the correct one.
There was a problem hiding this comment.
Resolved! Thanks
67a1f8e to
189af43
Compare
| description: Input fasta file containing query sequences | ||
| pattern: "*.{fa,fasta,fa.gz,fasta.gz}" | ||
| ontologies: | ||
| - edam: http://edamontology.org/format_1929 # FASTA |
| { assert process.success }, | ||
| { assert process.out.daa }, | ||
| { assert snapshot(process.out.versions).match("daa") } | ||
| { assert snapshot(process.out.findAll { key, val -> key.startsWith('versions') }).match("daa")} |
There was a problem hiding this comment.
Remove the match.daa
Your error says: "snapshot with id 'daa' not found."
Remove it and re-do the snapshots.
There was a problem hiding this comment.
Keep this: { assert snapshot(process.out.findAll { key, val -> key.startsWith('versions') }
| "0": [ | ||
|
|
||
| ], | ||
| "1": [ | ||
|
|
||
| ], | ||
| "2": [ | ||
| [ | ||
| { | ||
| "id": "fasta1", | ||
| "db": "db1" | ||
| }, | ||
| "fasta1.db1.txt:md5,2515cf88590afa32356497e79a51fce9" | ||
| ], | ||
| [ | ||
| { | ||
| "id": "fasta1", | ||
| "db": "db2" | ||
| }, | ||
| "fasta1.db2.txt:md5,8b41a8752379f7bd8722258962c598a4" | ||
| ], | ||
| [ | ||
| { | ||
| "id": "fasta2", | ||
| "db": "db1" | ||
| }, | ||
| "fasta2.db1.txt:md5,3be947b0e6c69c59491f817b03b1256f" | ||
| ], | ||
| [ | ||
| { | ||
| "id": "fasta2", | ||
| "db": "db2" | ||
| }, | ||
| "fasta2.db2.txt:md5,f2461bcecbf4f87cefe952179505aa8f" | ||
| ] |
There was a problem hiding this comment.
Everything here seems to be deleted. You need to update the snapshots or check why these changed.
|
|
||
| } | ||
|
|
||
| test("sarscov2 - proteome - double fasta/double db input") { |
There was a problem hiding this comment.
You need to re-run this test and have the snapshot because for some reason you are obtaining no-results while the snapshot (and the CI tests) produce results
PR checklist
Closes #10766
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda