Skip to content

Migration to topics channels: diamond/blastp #10766#10885

Open
LorenzoCampanelli1102 wants to merge 7 commits intonf-core:masterfrom
LorenzoCampanelli1102:module_diamond_blastp
Open

Migration to topics channels: diamond/blastp #10766#10885
LorenzoCampanelli1102 wants to merge 7 commits intonf-core:masterfrom
LorenzoCampanelli1102:module_diamond_blastp

Conversation

@LorenzoCampanelli1102
Copy link
Contributor

PR checklist

Closes #10766

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [ X] nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Contributor

@mantisps mantisps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check why the version captured is not the correct one. I believe the change you did on the version command affected something.

"DIAMOND_BLASTP",
"diamond",
"2.1.23"
"2.1.16"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something weird here.. The version number is not the correct one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved! Thanks

description: Input fasta file containing query sequences
pattern: "*.{fa,fasta,fa.gz,fasta.gz}"
ontologies:
- edam: http://edamontology.org/format_1929 # FASTA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the comment

{ assert process.success },
{ assert process.out.daa },
{ assert snapshot(process.out.versions).match("daa") }
{ assert snapshot(process.out.findAll { key, val -> key.startsWith('versions') }).match("daa")}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the match.daa

Your error says: "snapshot with id 'daa' not found."

Remove it and re-do the snapshots.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this: { assert snapshot(process.out.findAll { key, val -> key.startsWith('versions') }

Comment on lines -242 to -276
"0": [

],
"1": [

],
"2": [
[
{
"id": "fasta1",
"db": "db1"
},
"fasta1.db1.txt:md5,2515cf88590afa32356497e79a51fce9"
],
[
{
"id": "fasta1",
"db": "db2"
},
"fasta1.db2.txt:md5,8b41a8752379f7bd8722258962c598a4"
],
[
{
"id": "fasta2",
"db": "db1"
},
"fasta2.db1.txt:md5,3be947b0e6c69c59491f817b03b1256f"
],
[
{
"id": "fasta2",
"db": "db2"
},
"fasta2.db2.txt:md5,f2461bcecbf4f87cefe952179505aa8f"
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here seems to be deleted. You need to update the snapshots or check why these changed.


}

test("sarscov2 - proteome - double fasta/double db input") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to re-run this test and have the snapshot because for some reason you are obtaining no-results while the snapshot (and the CI tests) produce results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration to topics channels: diamond/blastp

3 participants