Skip to content

stageAs FASTQC input files to avoid basename file collisions#10924

Merged
tgelafr-pfzr merged 1 commit intonf-core:masterfrom
tgelafr-pfzr:bug/10923-fastqc-filename-collisions
Mar 16, 2026
Merged

stageAs FASTQC input files to avoid basename file collisions#10924
tgelafr-pfzr merged 1 commit intonf-core:masterfrom
tgelafr-pfzr:bug/10923-fastqc-filename-collisions

Conversation

@tgelafr-pfzr
Copy link
Contributor

@tgelafr-pfzr tgelafr-pfzr commented Mar 16, 2026

PR checklist

Closes #10923

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes filename collisions in the FASTQC module when multiple input files share the same basename (e.g., from different sequencing runs). It uses Nextflow's stageAs directive to place each input file in a uniquely numbered subdirectory.

Changes:

  • Added stageAs: '?/*' to the FASTQC input declaration to avoid basename collisions when staging input files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tgelafr-pfzr tgelafr-pfzr added this pull request to the merge queue Mar 16, 2026
Merged via the queue into nf-core:master with commit 6fbc98f Mar 16, 2026
64 checks passed
@tgelafr-pfzr tgelafr-pfzr deleted the bug/10923-fastqc-filename-collisions branch March 16, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FASTQC causes filename collisions when files with the same basename are being processed

3 participants