Skip to content

Conversation

@jfy133
Copy link
Member

@jfy133 jfy133 commented Oct 29, 2025

Same thing as here: #9163

Shuttling file symlinks (from filesystem outside work directory) inside directory symlinks (i.e., between processes), causes mounting issues with docker images.

This provides a way to remove the symlinking database directory between processes, and allowing docker or w/e to follow only file symlinks.

It's ugly, but it should work

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jfy133 jfy133 requested a review from Midnighter October 29, 2025 11:33
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the mv this process will be rerun each time a pipeline containing it will be resumed, as we just discussed, but as it seems that the issue can not be fixed in a different way, go ahead 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants