Skip to content

Conversation

@87xie
Copy link
Contributor

@87xie 87xie commented Sep 26, 2025

🔗 Linked issue

📚 Description

Similar to 840fe61

Before:

image

After:

image

Summary by CodeRabbit

  • Documentation
    • Updated header navigation to display link labels instead of titles, providing clearer, consistent link names across the docs navigation. This aligns visible text with how links are referred to elsewhere.
  • Style
    • Adjusts the link-title rendering in the navigation to use labels, improving readability without altering navigation behavior. Applies across all links in the header.

@87xie 87xie requested a review from BobbieGoede as a code owner September 26, 2025 06:34
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 26, 2025

Walkthrough

In docs/components/Header.vue, the template for UContentNavigation’s link-title slot was updated to render link.label instead of link.title. No control flow, data handling, or exports were modified. The change only affects which property is displayed for each link in the header navigation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Single-file, single-line UI binding change with no logic or structural edits; homogeneous and straightforward to verify.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately summarizes the primary change by indicating a fix to link label rendering in the mobile menu within the documentation, which directly matches the modifications made to the Header component. It is specific, clear, and free of vague language or unnecessary detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5afb642 and 29ff080.

📒 Files selected for processing (1)
  • docs/components/Header.vue (1 hunks)

Comment on lines 93 to 95
<span class="inline-flex items-center gap-0.5">
{{ link.title }}
{{ link.label }}
</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Retain a fallback to link.title.

Some navigation entries only define title (the default shape returned by @nuxt/content), so rendering link.label exclusively can surface blank menu rows. Keep the new label preference but fall back to title when the label is absent.

-            {{ link.label }}
+            {{ link.label ?? link.title }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<span class="inline-flex items-center gap-0.5">
{{ link.title }}
{{ link.label }}
</span>
<span class="inline-flex items-center gap-0.5">
{{ link.label ?? link.title }}
</span>
🤖 Prompt for AI Agents
In docs/components/Header.vue around lines 93 to 95, the template currently
renders only link.label which can be undefined for entries that only provide
title; update the rendering to prefer link.label but fall back to link.title
when label is absent (e.g., use a conditional or logical-or expression to
display link.label || link.title) so menu rows are never blank.

Copy link
Member

@BobbieGoede BobbieGoede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@BobbieGoede BobbieGoede merged commit d0726e1 into nuxt-modules:main Oct 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants