Skip to content

docs: fix link label rendering in mobile menu #3829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2025
Merged

docs: fix link label rendering in mobile menu #3829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/components/Header.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const processed = computed<DropdownMenuItem[]>(() => {
>
<template #link-title="{ link }">
<span class="inline-flex items-center gap-0.5">
{{ link.title }}
{{ link.label }}
</span>
Comment on lines 93 to 95
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Retain a fallback to link.title.

Some navigation entries only define title (the default shape returned by @nuxt/content), so rendering link.label exclusively can surface blank menu rows. Keep the new label preference but fall back to title when the label is absent.

-            {{ link.label }}
+            {{ link.label ?? link.title }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<span class="inline-flex items-center gap-0.5">
{{ link.title }}
{{ link.label }}
</span>
<span class="inline-flex items-center gap-0.5">
{{ link.label ?? link.title }}
</span>
🤖 Prompt for AI Agents 
In docs/components/Header.vue around lines 93 to 95, the template currently
renders only link.label which can be undefined for entries that only provide
title; update the rendering to prefer link.label but fall back to link.title
when label is absent (e.g., use a conditional or logical-or expression to
display link.label || link.title) so menu rows are never blank.

</template>
</UContentNavigation>
Expand Down