-
Notifications
You must be signed in to change notification settings - Fork 14
feat: port tab view feature from upstream PRs #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port tab view feature from upstream PRs #103
Conversation
|
If you'd like to try it out before this PR is merged, please replace the corresponding plugin files (main.js and styles.css) in .obsidian/plugins/obsidian-spaced-repetition-recall with those from patch.zip. |
f25e66f
into
open-spaced-repetition:dev-master
|
@bcdax110 你好,这个pr还没能实现tab复习卡片,编译报错,希望能补充完善相关文件 |
@Newdea 没有看到有报错的地方。 有没有具体的报错信息是什么,可不可以发出来看看,我这边目前没有办法复现。 |
|
我也尝试了 |
|
可能是你环境混乱了吧,我在本地和vscode.dev网页上build 都报错如下 |
我好像搞清楚什么问题了,我在之前 commit 的时候 IDE 出 bug 了,添加到 change 之后自己变成 unversioned 了,有点尴尬,我这就把这几个文件推上去。 |
|
嗯,我也在尝试合并主分支最新版了,但冲突太多,不好处理😮💨 |
我把没有进到版本管理的文件加进去了,重新提了 PR #105 ,我这次在别的目录重新克隆的 frok 仓库尝试了一下,应该不会有缺失的文件了。 感觉上游的变动还是得把 PR 一部分一部分的重新加进去,合并是没发合并了。 |
…#105) Co-authored-by: bcdax110 <[email protected]>
port tab view feature from upstream PRs: