Skip to content

feat: port tab view feature from upstream PRs #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

feat: port tab view feature from upstream PRs #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58c7165
feat: Add a setting to choose between opening in a modal or a tab
May 2, 2025
9fa722f
feat: Implemented tab view
May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,5 @@ export const TICKS_PER_DAY = 24 * 3600 * 1000;
export const SR_HTML_COMMENT_BEGIN = "<!--SR:";
export const SR_HTML_COMMENT_END = "-->";

export const SR_TAB_VIEW = "spaced-repetition-recall-tab-view";
export const DEFAULT_DECKNAME = "default";
236 changes: 0 additions & 236 deletions src/gui/DeckListView.tsx
View file
Open in desktop

This file was deleted.

21 changes: 11 additions & 10 deletions src/gui/FlashcardModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,24 @@ import {
IFlashcardReviewSequencer as IFlashcardReviewSequencer,
} from "src/FlashcardReviewSequencer";
import { FlashcardEditModal } from "./EditModal";
import { DeckListView } from "./DeckListView";
import { FlashcardReviewView } from "./FlashcardReviewView";
import { DeckUI } from "./DeckUI";
import { CardUI } from "./CardUI";

export enum FlashcardModalMode {
DecksList,
export enum FlashcardMode {
Deck,
Front,
Back,
Closed,
}

export class FlashcardModal extends Modal {
public plugin: SRPlugin;
public mode: FlashcardModalMode;
public mode: FlashcardMode;
private reviewSequencer: IFlashcardReviewSequencer;
private settings: SRSettings;
private reviewMode: FlashcardReviewMode;
private deckView: DeckListView;
private flashcardView: FlashcardReviewView;
private deckView: DeckUI;
private flashcardView: CardUI;

constructor(
app: App,
Expand All @@ -56,15 +56,15 @@ export class FlashcardModal extends Modal {
this.contentEl.addClass("sr-modal-content");

// Init static elements in views
this.deckView = new DeckListView(
this.deckView = new DeckUI(
this.plugin,
this.settings,
this.reviewSequencer,
this.contentEl,
this._startReviewOfDeck.bind(this),
);

this.flashcardView = new FlashcardReviewView(
this.flashcardView = new CardUI(
this.app,
this.plugin,
this.settings,
Expand All @@ -82,9 +82,10 @@ export class FlashcardModal extends Modal {
}

onClose(): void {
this.plugin.setSRViewInFocus(false);
this.mode = FlashcardMode.Closed;
this.deckView.close();
this.flashcardView.close();
this.mode = FlashcardModalMode.Closed;
}

private _showDecksList(): void {
Expand Down
Loading
Loading